Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
637
KerrieHart
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Logic error in vnum ran...
Forum Rules | Mark all | Recent Posts

[Bug] Logic error in vnum range checks for do_minvoke and do_oinvoke
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Apr 7, 2005, 7:26 pm   Last edited May 6, 2005, 12:13 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Logic error in vnum range checks for do_minvoke and do_oinvoke
Danger: Trivial - Code check does nothing.
Found by: Zeno
Fixed by: Zeno

---

In act_wiz.c, under do_minvoke and do_oinvoke:

      if( vnum < pArea->low_o_vnum && vnum > pArea->hi_o_vnum )
      {
         send_to_char( "That number is not in your allocated range.\n\r", ch );
         return;
      }


Change it to:
      if( vnum < pArea->low_o_vnum || vnum > pArea->hi_o_vnum )
      {
         send_to_char( "That number is not in your allocated range.\n\r", ch );
         return;
      }


The if check in both functions is checking to see if a vnum is less than the low number, AND greater than the high number. This is obviously impossible and so the check will simply drop through to the next lines of code. Replacing it with an OR check will make it work as intended.
       
Pages:<< prev 1 next >>