Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Bing, DotBot, Yandex, Google

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
481
3,739
19,386
622
ignatius
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Deity worshipper count ...
Forum Rules | Mark all | Recent Posts

[Bug] Deity worshipper count can go negative in do_devote
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 9, 2005, 7:58 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Deity worshipper count is not safeguarded against going negative in do_devote
Danger: Low - Incorrect counter value
Found by: Celestria
Fixed by: Celestria

---

deity.c, do_devote

Locate:

      if( !ch->pcdata->deity )
      {
         send_to_char( "You have already chosen to worship no deities.\n\r", ch );
         return;
      }
      --ch->pcdata->deity->worshippers;


Change to:

      if( !ch->pcdata->deity )
      {
         send_to_char( "You have already chosen to worship no deities.\n\r", ch );
         return;
      }
      --ch->pcdata->deity->worshippers;
      if( ch->pcdata->deity->worshippers < 0 )
         ch->pcdata->deity->worshippers = 0;


Players who choose to "devote none" were not adjusting the worshipper count. As far as I'm aware, this doesn't cause any significant harm in the long run, but accuracy of information is still important.
       
Pages:<< prev 1 next >>