Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex, DotBot

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
481
3,735
19,369
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Memory leak in read_pro...
Forum Rules | Mark all | Recent Posts

[Bug] Memory leak in read_project at bootup
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005, 4:03 pm   Last edited May 11, 2005, 6:49 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Memory leak in read_project at bootup.
Danger: Low
Found by: Samson
Fixed by: Samson

read_project, db.c:

Find:

	case 'N':
     if ( !str_cmp(word, "Name";) )
      STRFREE(project->name );
     KEY( "Name",  	project->name,  	fread_string_nohash( fp ) );
  break;


Replace it with:

	case 'N':
     if ( !str_cmp(word, "Name";) )
              if( project->name )
      DISPOSE(project->name );
     KEY( "Name",  	project->name,  	fread_string_nohash( fp ) );
  break;


There is also an initializer line further up in the code that reads:

   project->name = STRALLOC( "" );


This should read:

   project->name = NULL;


Near the bottom you also have this:

  if ( project->name )
  	STRFREE( project->name );


That should be changed to:

  if ( project->name )
  	DISPOSE( project->name );


This is listed as low danger because the memory leak only occurs at bootup.
       
Pages:<< prev 1 next >>