SmaugMuds.org - Viewing Topic: [Bug] load_rooms doesn't properly check sector types when loading rooms

» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] load_rooms doesn't prop...

Forum Rules | Mark all | Recent Posts

[Bug] load_rooms doesn't properly check sector types when loading rooms

< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>

#1 Mar 5, 2005, 3:58 pm Last edited May 11, 2005, 6:40 pm by Samson

Samson
Black Hand

GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: The load_rooms function doesn't properly check sector types when loading a room.
Danger: High
Found by: Remcon
Fixed by: Remcon
-----
[db.c]

In load_rooms find:

        if (pRoomIndex->sector_type < 0 || pRoomIndex->sector_type == SECT_MAX)
        {
          bug( "Fread_rooms: vnum %d has bad sector_type %d.", vnum ,
              pRoomIndex->sector_type);
          pRoomIndex->sector_type = 1;
        }

Change it to:

        if (pRoomIndex->sector_type < 0 || pRoomIndex->sector_type >= SECT_MAX)
        {
          bug( "Fread_rooms: vnum %d has bad sector_type %d.", vnum ,
              pRoomIndex->sector_type);
          pRoomIndex->sector_type = 1;
        }

This can be bad because new areas may have sectors greater than SECT_MAX, and the code doesn't properly check for this.

Pages:<< prev 1 next >>