Samson said:In all honesty, no offense to Senir, but I find Remcon's version of it much more friendly:
Remcon's helpfile code
It performs the same function and has not been shown to be unstable. He has allowed me to include it in AFKMud, and he uses it on his own Smaug deriv. The code doesn't seem to have received nearly the attention it deserves for some reason.
However, it is not technically considered a bugfix and there just isn't the kind of demand behind this feature like there was to get hotboot added as a standard.
Hmm. I believe there was an issue with part of the original code, not just the similar helpfiles snippet, that led to the problems encountered when the snippet searched through the helpfiles to find similar entries.
Basically the change was here (act_info.c, get_help function):
if ( isdigit( argument[0] ) && !is_number(argument))
I believe the !is_number(argument) was the addition.
Though I don't fully recall and didn't read through the whole thread again, I think the issue was level requests being confused with numbers in the helpfile names somehow. This particular fix was supposed to prevent helpfile names like "123" from causing a loop because the name was being taken as a helpfile level.
Anyway, I thought this information might be useful. I would think this could apply to both snippets, but I've not looked at Remcon's so I'm not sure if it would cause a problem there. In any event, hope the info is useful to someone.