Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Development
Nov 28, 2018, 10:10 am
By Keirath
First Immortal
Oct 12, 2018, 12:02 pm
By GatewaySysop
Bug in do_climb( )
Jun 5, 2018, 5:31 pm
By joeyfogas
question on overland code
May 31, 2018, 10:03 am
By joeyfogas
KaVir's Protocol Snip
May 15, 2018, 7:57 pm
By joeyfogas
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, DotBot, Bing

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
481
3,740
19,397
640
KieraZajac
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Port numbers sometimes ...
Forum Rules | Mark all | Recent Posts

[Bug] Port numbers sometimes show up in logs with negative values
< Newer Topic :: Older Topic > AFKMud 1.77

Pages:<< prev 1 next >>
Post is unread #1 Sep 30, 2006, 9:43 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,644
JoinedJan 1, 2002

Bug: Port numbers sometimes show up in logs with negative values
Danger: Trivial - Display only bug.
Discovered in: AFKMud 1.77
Found by: Remcon
Fixed by: Remcon

---

comm.c, nanny

Locate:
         log_printf_plus( LOG_COMM, LEVEL_KL, "Incoming connection: %s, port %hd.", d->host, d->port );


Change to:
         log_printf_plus( LOG_COMM, LEVEL_KL, "Incoming connection: %s, port %d.", d->host, d->port );


This is a very subtle one to spot, but it makes all the difference when displaying the value. %hd is the formatting tag for a signed short, while %d is the formatting tag for an int. Since port numbers can go to 65535, a signed short isn't the proper size to display it.
       
Pages:<< prev 1 next >>