User Name:


Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!

Members: 0
Guests: 14
Newest Member
Today's Birthdays
Evoru (32)
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Deleting a room with th...
Forum Rules | Mark all | Recent Posts

[Bug] Deleting a room with the at command can lead to disaster
< Newer Topic :: Older Topic > AFKMud 1.77

Pages:<< prev 1 next >>
Post is unread #1 Sep 24, 2006, 2:17 pm
Go to the top of the page
Go to the bottom of the page

Black Hand
JoinedJan 1, 2002

Bug: Deleting a room with the at command can lead to disaster
Danger: High - Potential crash situation. Corrupted room pointer.
Discovered in: AFKMud 1.77
Found by: Remcon
Fixed by: Samson


handler.c, char_to_room

   if( !ch )
      bug( "%s", "Char_to_room: NULL ch!" );
      return FALSE;

Below that, add:
   if( !get_room_index( pRoomIndex->vnum ) )
      pRoomIndex = NULL;

This simple, yet hackish solution is probably not necessary in 99% of cases. But it's always that 1% that bites you in the ass every time. Invision this: You're in a room. For whatever reason you get the urge to type "rdelete <remote room#> <room# you're in now>" and voila! The command succeeded.... but... wait. You're back in the room you just told the code to delete. Uh oh. Yeah, I bet you can see that any attempt to remove yourself from this situation isn't going to be good. But with this fix in place, you get a bit of bug spam and a free trip to Limbo instead. Assuming you HAVE a limbo room. But that's a whole other can of worms.
Pages:<< prev 1 next >>