Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
tintin++ ogg sound player script for linux
Author: Robert Smith
Submitted by: Vladaar
6Dragons ogg Soundpack
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
Users Online
CommonCrawl, Yandex, DotBot

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
481
3,734
19,366
618
Micheal64X
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Deity worshipper count ...
Forum Rules | Mark all | Recent Posts

[Bug] Deity worshipper count is not being adjusted in do_mset
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Feb 28, 2005, 5:31 pm   Last edited Nov 13, 2005, 11:54 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,643
JoinedJan 1, 2002

Bug: Deity worshipper count is not being adjusted in do_mset
Discovered in: AFKMud 1.64
Danger: Trivial ( if pfile clean is on ) / Low ( if pfile cleanup is off ) - Incorrect counter value
Found by: Celestria
Fixed by: Samson

---

deity.h

At the bottom of the file, add:

void save_deity( DEITY_DATA *deity );


build.c, do_mset

Locate:

      if( !arg3 || arg3[0] == '\0' )
        {
            STRFREE( victim->pcdata->deity_name );
            victim->pcdata->deity = NULL;
            send_to_char( "Deity removed.\n\r", ch );
            return;
        }


Change to:

      if( !arg3 || arg3[0] == '\0' )
      {
         if( victim->pcdata->deity )
         {
            --victim->pcdata->deity->worshippers;
            if( victim->pcdata->deity->worshippers < 0 )
               pcdata->deity->worshippers = 0;
            save_deity( victim->pcdata->deity );
         }
         STRFREE( victim->pcdata->deity_name );
         victim->pcdata->deity = NULL;
         send_to_char( "Deity removed.\n\r", ch );
         return;
      }


Locate:

        STRFREE( victim->pcdata->deity_name );
        victim->pcdata->deity_name = QUICKLINK( deity->name );
        victim->pcdata->deity = deity;
        send_to_char( "Done.\n\r", ch );


Change to:

      if( victim->pcdata->deity )
      {
         --victim->pcdata->deity->worshippers;
         if( victim->pcdata->deity->worshippers < 0 )
            pcdata->deity->worshippers = 0;
         save_deity( victim->pcdata->deity );
      }
      STRFREE( victim->pcdata->deity_name );
      victim->pcdata->deity_name = QUICKLINK( deity->name );
      victim->pcdata->deity = deity;
      ++deity->worshippers;
      save_deity( deity );
      send_to_char( "Done.\n\r", ch );


Removing a deity from a player manually via mset was not adjusting the worshipper count. As far as I'm aware, this doesn't cause any significant harm in the long run, but accuracy of information is still important. The affect of this bug is mitigated to nothing if you have the pfile autocleanup code enabled in cset, the counts will be adjusted automatically at the next update cycle. If not, then the counts will never be updated, they will just be wrong until someone either enables the cleanup, or fixes the files manually.
       
Pages:<< prev 1 next >>