Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Bing, DotBot, Yandex

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
614
BenitoVirg
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] save_equipment array is...
Forum Rules | Mark all | Recent Posts

[Bug] save_equipment array is defined with a hardcoded value
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 22, 2005, 6:41 pm   Last edited Nov 13, 2005, 11:57 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: save_equipment array is defined with a hardcoded value.
Discovered in: AFKMud 1.64
Danger: Medium - Data will only be affected if MAX_LAYERS value is raised beyond the limit.
Found by: Samson
Fixed by: Samson

---

save.c, locate:

/*
 * Array to keep track of equipment temporarily.                -Thoric
 */
OBJ_DATA *save_equipment[MAX_WEAR][8];
OBJ_DATA *mob_save_equipment[MAX_WEAR][8];
CHAR_DATA *quitting_char, *loading_char, *saving_char;


Change to:

/*
 * Array to keep track of equipment temporarily.                -Thoric
 */
OBJ_DATA *save_equipment[MAX_WEAR][MAX_LAYERS];
OBJ_DATA *mob_save_equipment[MAX_WEAR][MAX_LAYERS];
CHAR_DATA *quitting_char, *loading_char, *saving_char;


The save_equipment and mob_save_equipment arrays are temporary storage spaces for equipment locations during certain operations. The external definition in mud.h defines the second array parameter as MAX_LAYERS, which by default is set to 8. Normally this creates no issues since it's doubtful many muds use more than 8 layers for any locations. However, should this value be raised, then the declaration in save.c will be invalid and cause overflows when the space is used.
       
Pages:<< prev 1 next >>