Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex

Members: 0
Guests: 18
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] free_shellcommands is n...
Forum Rules | Mark all | Recent Posts

[Bug] free_shellcommands is not unlinking entries from the list
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 9, 2005, 2:24 am   Last edited Nov 13, 2005, 12:01 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: free_shellcommands is not unlinking entries from the list
Discovered in: AFKMud 1.64
Danger: Low - Only applicable during shutdown or reboot
Found by: Samson
Fixed by: Samson

---

In shell.c, locate:

void free_shellcommands( void )
{
   SHELLCMD *scommand, *scmd_next;

   for( scommand = first_shellcmd; scommand; scommand = scmd_next )
   {
      scmd_next = scommand->next;
      free_shellcommand( scommand );
   }
   return;
}


Replace with:

void free_shellcommands( void )
{
   SHELLCMD *scommand, *scmd_next;

   for( scommand = first_shellcmd; scommand; scommand = scmd_next )
   {
      scmd_next = scommand->next;

      UNLINK( scommand, first_shellcmd, last_shellcmd, next, prev );
      free_shellcommand( scommand );
   }
   return;
}


Ordinarily such a bug would be a bad thing since it's a memory leak. However since free_shellcommands is only called by cleanup_memory this results in nothing more than a potential annoyance during shutdowns and reboots. Valgrind users may get warnings about lost blocks during debugging.
       
Pages:<< prev 1 next >>