Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 12
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] KEY macro is not comple...
Forum Rules | Mark all | Recent Posts

[Bug] KEY macro is not completely safeguarded
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 8, 2005, 2:26 pm   Last edited Nov 13, 2005, 12:02 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: KEY macro is not completely safeguarded.
Discovered in: AFKMud 1.64
Danger: Low
Found by: Samson
Fixed by: Samson

---

In mud.h, locate:

/* This damn thing is used in so many places it was about time to just move it here - Samson 10-4-03 */
#define KEY( literal, field, value )                                    
if( !str_cmp( word, literal ) )      
{                                    
                                      field = value;                    
                                      fMatch = TRUE;                    
                                      break;                            
}


Replace it with:

/* This damn thing is used in so many places it was about time to just move it here - Samson 10-4-03 */
#define KEY( literal, field, value ) 
if( !str_cmp( word, (literal) ) )  
{                                    
   (field) = (value);                
   fMatch = true;                    
   break;                            
}


The only actual change here is that the "literal", "field", and "value" parameters have parenthesis around them when used inside the macro definition. This usually isn't an issue but on some systems data can be misread.

This issue also affects the Smaug codebases. The KEY macro is redefined in tons of places though, so fixing it there becomes much more of a chore.
       
Pages:<< prev 1 next >>