Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Yahoo!

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » AFKMud Bug Archive » [Bug] Name auth listings for ...
Forum Rules | Mark all | Recent Posts

[Bug] Name auth listings for changed names are not properly reallocated
< Newer Topic :: Older Topic > AFKMud 1.64

Pages:<< prev 1 next >>
Post is unread #1 Jan 7, 2005, 8:11 pm   Last edited Nov 13, 2005, 12:02 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Name authorization listings for changed names are not being properly reallocated.
Discovered in: AFKMud 1.64
Danger: Medium - Memory leak
Found by: Samson
Fixed by: Samson

---

new_auth.c, find the do_name function.

Locate:
  STRFREE( ch->name );
  ch->name = STRALLOC( argument );
  STRFREE( ch->pcdata->filename );
  ch->pcdata->filename = STRALLOC( argument );
  send_to_char( "Your name has been changed and is being submitted for approval.\n\r", ch ); 
  auth_name->name = STRALLOC( argument );
  auth_name->state = AUTH_ONLINE;
  STRFREE( auth_name->change_by );        
  save_auth_list();
  return;


Replace that segment with this:

   STRFREE( ch->name );
   ch->name = STRALLOC( argument );
   STRFREE( ch->pcdata->filename );
   ch->pcdata->filename = STRALLOC( argument );
   send_to_char( "Your name has been changed and is being submitted for approval.\n\r", ch );
   STRFREE( auth_name->name );
   auth_name->name = STRALLOC( argument );
   auth_name->state = AUTH_ONLINE;
   STRFREE( auth_name->change_by );
   save_auth_list(  );
   return;


When a player changes names using the do_name code, the auth list is supposed to get updated to reflect the new name being submitted for authorization. However, the old name that was previously in the list is never freed beforehand and results in a memory leak. Compounded over enough time this will lead to degraded performance of the MUD.

This particular issue also affects the name authorization snippet code which has been corrected.
       
Pages:<< prev 1 next >>