Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Majestic-12

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » General » Smaug Snippets » Pfile Snippet
Forum Rules | Mark all | Recent Posts

Pfile Snippet
< Newer Topic :: Older Topic > Memory leak

Pages:<< prev 1 next >>
Post is unread #1 Feb 11, 2004, 11:28 am   Last edited Nov 23, 2007, 11:52 pm by Samson
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

I beleive that there is a memory leak in the pfile pruning snippet. While the various fields are read in with fread_string and assigned into clan, name, and I think deity, they are not freed. I beleive that something like this is need at the bottom of the function:
   if( deity != NULL )
   {
	DEITY_DATA *god = get_deity( deity );

	if( god )
         god->worshippers++;
   }
   
   if ( clan )
      STRFREE( clan );
   if ( name )
      STRFREE( name );
   if ( deity )
      STRFREE( deity );
   return;
I duno, maybe I'm insane...
       
Post is unread #2 Feb 11, 2004, 11:50 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Your not insane. Many of the snippets survived by making use of the existing infrastructure available in Smaug at the time and were often released before I had a clear understanding of memory leakage and such. When I get some time I'll go through and update these things. If you find more, post them
       
Post is unread #3 Feb 11, 2004, 11:53 am
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

I've tested it, and it looks like that those are not the only leaks in the command, when I track it down I'll post the fix.
       
Post is unread #4 Feb 13, 2004, 11:06 am
Go to the top of the page
Go to the bottom of the page

Greven
Magician
GroupMembers
Posts204
JoinedMar 5, 2005

Well, it looks like the current version of the snippet, with the STRFREE's, should do the trick, the memory leaks I was still having involved modifications I had done, with a return that was ending the function early. The stock one should work just fine.
       
Pages:<< prev 1 next >>