Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SmaugFUSS » Bug in disarm( )
Forum Rules | Mark all | Recent Posts

Bug in disarm( )
< Newer Topic :: Older Topic > Missing check for remove progs...

Pages:<< prev 1 next >>
Post is unread #1 Nov 6, 2017, 9:21 pm
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts367
JoinedMar 7, 2005

Another one that popped up in play testing (I should do more of that!). When being disarmed, the remove progs are not being checked. Easy fix though! :wink:

In skills.c, function disarm( ), around here:

   if( obj == get_eq_char( victim, WEAR_WIELD ) && ( tmpobj = get_eq_char( victim, WEAR_DUAL_WIELD ) ) != NULL )
      tmpobj->wear_loc = WEAR_WIELD;

   obj_from_char( obj );


Consider adding this:

   if( obj == get_eq_char( victim, WEAR_WIELD ) && ( tmpobj = get_eq_char( victim, WEAR_DUAL_WIELD ) ) != NULL )
      tmpobj->wear_loc = WEAR_WIELD;

   oprog_remove_trigger( victim, obj );

   obj_from_char( obj );


       
Post is unread #2 Nov 7, 2017, 4:19 pm
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,866
JoinedJul 26, 2005

This one I remember from being a player...now that you mention it. It was the only way to remove some items that would use triggers to keep you from removing it.
       
Post is unread #3 Nov 12, 2017, 6:54 pm   Last edited Nov 12, 2017, 6:57 pm by GatewaySysop
Go to the top of the page
Go to the bottom of the page

GatewaySysop
Conjurer
GroupMembers
Posts367
JoinedMar 7, 2005

Remcon said:

This one I remember from being a player...now that you mention it. It was the only way to remove some items that would use triggers to keep you from removing it.


Yup. And if I recall other bugs, it was also possible to use disarm to remove what should be non-removable items. Lots of holes in that disarm code, which is surprising given that it must have been a widely exploited set of bugs and, presumably, well known. How nobody caught it and/or fixed it sooner is seriously beyond me. :shrug:

I need to do more play testing and catch more of these bugs. :imp:
       
Pages:<< prev 1 next >>