Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » Memory leak with do_hset and ...
Forum Rules | Mark all | Recent Posts

Memory leak with do_hset and smash_tilde_copy?
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 4, 2016, 11:43 pm
Go to the top of the page
Go to the bottom of the page

Kasji
Apprentice
GroupMembers
Posts62
JoinedDec 23, 2007

So, do_hset uses smash_tilde_copy.

smash_tilde_copy uses strdup and returns a pointer to this duplicate string.

do_hset doesn't free this string.

Isn't this a memory leak?
       
Post is unread #2 Sep 5, 2016, 9:10 pm
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,866
JoinedJul 26, 2005

great find, feel free to fix it and post a fix for everyone, if you would like to :)
       
Post is unread #3 Sep 7, 2016, 4:29 pm   Last edited Sep 7, 2016, 4:36 pm by Kasji
Go to the top of the page
Go to the bottom of the page

Kasji
Apprentice
GroupMembers
Posts62
JoinedDec 23, 2007

This may be arbitrary as both solutions are "equal" (haven't tested them though). But as far as style or standards goes, which would you consider more conformant?

free(argument);


or

argument = smash_tilde(argument);


Assuming that this is a standard across all codebases:

const char * smash_tilde(const char *);


I'm compiling on g++ and most of my char * argument's have been turned into const char *.
       
Pages:<< prev 1 next >>