Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Couple bugs
Yesterday, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex, DotBot, Bing, Google

Members: 0
Guests: 6
Stats
Files
Topics
Posts
Members
Newest Member
477
3,705
19,232
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » BUG in do_rpconvert
Forum Rules | Mark all | Recent Posts

BUG in do_rpconvert
< Newer Topic :: Older Topic > Likely an oversight:

Pages:<< prev 1 next >>
Post is unread #1 Oct 27, 2011, 6:21 pm
Go to the top of the page
Go to the bottom of the page

ayuri
Magician
GroupMembers
Posts239
JoinedJun 13, 2008

Poking about even more, I've noticed that do_rpconvert doesn't check to see if the class you've selected is already at max level.

Example:
I have 30 out of 30 combat levels, I spend rpp via rpconvert to increase combat by 1. It takes my rpp, but won't set me to combat level 31 as that is beyond the defined max level.

ayuri
       
Post is unread #2 Oct 27, 2011, 8:59 pm
Go to the top of the page
Go to the bottom of the page

Aurin
Magician
GroupMembers
Posts189
JoinedSep 5, 2010

in do_rpconvert, towards the top, but below the other sanity checks, add a check to see if you're already at max level. if you are, return out of function. :P This stops the process and saves the rpp...you can also send a message to the player about why it didn't work at the same time.
       
Post is unread #3 Oct 27, 2011, 9:30 pm   Last edited Oct 27, 2011, 10:43 pm by ayuri
Go to the top of the page
Go to the bottom of the page

ayuri
Magician
GroupMembers
Posts239
JoinedJun 13, 2008

You got it, just haven't set up a fix yet as I found it at work while I was adding in more bonuses. Wanted to at least get it posted. :D
**EDIT my quick and dirty method to just dump it out is this:
In misc.c do_rpconvert
find:
 if( UPPER( argument[0] ) == UPPER( ability_name[iClass][0] )
                                        && !str_prefix( argument, ability_name[iClass] ) && str_prefix( argument, "force" ))


And change it to:
                        if( UPPER( argument[0] ) == UPPER( ability_name[iClass][0] )
                                        && !str_prefix( argument, ability_name[iClass] ) && str_prefix( argument, "force" )
                                        && (max_level(ch, iClass) < 30) )


Granted you could clean it up, but it gets the point across :biggrin:
ayuri
       
Pages:<< prev 1 next >>