Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Bing

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
477
3,705
19,232
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Weather system uses cop...
Forum Rules | Mark all | Recent Posts

[Bug] Weather system uses copy of old URANGE macro
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 10, 2010, 4:40 pm
Go to the top of the page
Go to the bottom of the page

Kayle
Off the Edge of the Map
GroupAdministrators
Posts1,195
JoinedMar 21, 2006

Bug: Weather system uses copy of old URANGE macro.
Danger: Medium - Could result in bogus math and things returning wrong..
Found by: Kayle
Fixed by: Kayle

---

weather.h

Find and remove the WRANGE macro.

weather.c, ApplyDeltaChanges
Find:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature	= WRANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure		= WRANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover    = WRANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy		= WRANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity		= WRANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = WRANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX	= WRANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY	= WRANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


Replace with:
         //Here we actually apply the changes making sure they stay within specific bounds
         cell->temperature = URANGE( -30, cell->temperature + delta->temperature, 100 );
         cell->pressure = URANGE( 0, cell->pressure + delta->pressure, 100 );
         cell->cloudcover = URANGE( 0, cell->cloudcover + delta->cloudcover, 100 );
         cell->energy = URANGE( 0, cell->energy + delta->energy, 100 );
         cell->humidity = URANGE( 0, cell->humidity + delta->humidity, 100 );
         cell->precipitation = URANGE( 0, cell->precipitation + delta->precipitation, 100 );
         cell->windSpeedX = URANGE( -100, cell->windSpeedX + delta->windSpeedX, 100 );
         cell->windSpeedY = URANGE( -100, cell->windSpeedY + delta->windSpeedY, 100 );


This was an attempt to make the system as reliant on the codebase as possible but ended up just causing issues. So we'll just avoid those issues by using the urange call from the codebase.
       
Pages:<< prev 1 next >>