SmaugMuds.org - Viewing Topic: do_clan_withdraw/donate, character not saved

» SmaugMuds.org » Codebases » SWR FUSS » do_clan_withdraw/donate, char...

Forum Rules | Mark all | Recent Posts

do_clan_withdraw/donate, character not saved

< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>

#1 Oct 22, 2009, 10:34 pm

Caius
Magician

GroupMembers
Posts100
JoinedJan 29, 2006 WWW

clans.c, do_clan_withdraw() and do_clan_donate(), at the bottom

Code:

/* This example is do_clan_withdraw() */
clan->funds -= amount;
ch->gold += amount;
save_clan ( clan );

Change to:

Code:

clan->funds -= amount;
ch->gold += amount;
save_char_obj( ch );
save_clan ( clan );

Add save_char_obj to do_clan_donate as well in the same manner.

Money is deducted from clan and added to character. The clan is saved to disk, while the character is not. In case of a crash or similar, the money will simply vanish. .........................
SWR2 Refactor - The improved SWR 2.0 codebase.

#2 Oct 30, 2009, 7:26 pm

ayuri
Magician

GroupMembers
Posts110
JoinedJun 13, 2008

Correct me if I'm wrong here, but by calling save_char_obj() doesn't that save the clan data anyway if they are in a clan? Seeing how only clan members would have access to that.

Is it worth saving the clan data twice?

Just wondering.
ayuri .........................
"There is a lesson here for ambitious system architects: the most dangerous enemy of a better solution is an existing codebase that is just good enough."
-- Eric S. Raymond: The Art of Unix Programming

#3 Oct 30, 2009, 8:17 pm

Caius
Magician

GroupMembers
Posts100
JoinedJan 29, 2006 WWW

Yeah, you're right. But the bug still remains. The character isn't saved. .........................
SWR2 Refactor - The improved SWR 2.0 codebase.

Pages:<< prev 1 next >>