Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Sogou, DotBot

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » LoP Bugfix List » Sset issue
Forum Rules | Mark all | Recent Posts

Sset issue
< Newer Topic :: Older Topic > Crashing and memory problem

Pages:<< prev 1 next >>
Post is unread #1 Feb 13, 2009, 5:35 pm
Go to the top of the page
Go to the bottom of the page

Remcon
Geomancer
GroupAdministrators
Posts1,866
JoinedJul 26, 2005

in skills.c function do_sset
find
         CREATE( aff, SMAUG_AFF, 1 );
         if( !str_cmp( duration, "0" ) )
            duration[0] = '\0';
         if( !str_cmp( modifier, "0" ) )
            modifier[0] = '\0';
         if( ( loc % REVERSE_APPLY ) == APPLY_EXT_AFFECT )
         {
            int modval = get_flag( modifier, a_flags, AFF_MAX );

            if( modval < 0 || modval >= AFF_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown affect: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         else if( ( loc % REVERSE_APPLY ) == APPLY_RESISTANT
         || ( loc % REVERSE_APPLY ) == APPLY_IMMUNE
         || ( loc % REVERSE_APPLY ) == APPLY_SUSCEPTIBLE
         || ( loc % REVERSE_APPLY ) == APPLY_ABSORB )
         {
            int modval = get_flag( modifier, ris_flags, RIS_MAX );

            if( modval < 0 || modval >= RIS_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown resistant/immune/susceptible/absorb: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         if( ( loc % REVERSE_APPLY ) >= APPLY_STRIPSN && ( loc % REVERSE_APPLY ) < APPLY_STAT )
            if( duration == NULL || duration[0] == '\0' )
               snprintf( duration, sizeof( duration ), "%d", 0 );
         aff->duration = STRALLOC( duration );

change it to
         if( !str_cmp( duration, "0" ) )
            duration[0] = '\0';
         if( !str_cmp( modifier, "0" ) )
            modifier[0] = '\0';
         if( ( loc % REVERSE_APPLY ) == APPLY_EXT_AFFECT )
         {
            int modval = get_flag( modifier, a_flags, AFF_MAX );

            if( modval < 0 || modval >= AFF_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown affect: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         else if( ( loc % REVERSE_APPLY ) == APPLY_RESISTANT
         || ( loc % REVERSE_APPLY ) == APPLY_IMMUNE
         || ( loc % REVERSE_APPLY ) == APPLY_SUSCEPTIBLE
         || ( loc % REVERSE_APPLY ) == APPLY_ABSORB )
         {
            int modval = get_flag( modifier, ris_flags, RIS_MAX );

            if( modval < 0 || modval >= RIS_MAX )
            {
               modval = 0;
               ch_printf( ch, "Unknown resistant/immune/susceptible/absorb: %s.\r\n", modifier );
               return;
            }
            snprintf( modifier, sizeof( modifier ), "%d", modval );
         }
         if( ( loc % REVERSE_APPLY ) >= APPLY_STRIPSN && ( loc % REVERSE_APPLY ) < APPLY_STAT )
            if( duration == NULL || duration[0] == '\0' )
               snprintf( duration, sizeof( duration ), "%d", 0 );
         if( ( loc % REVERSE_APPLY ) == APPLY_WAITSTATE && ( modifier == NULL || modifier[0] == '\0' ) )
         {
            send_to_char( "You can't affect waitsate by nothing.\r\n", ch );
            return;
         }
         CREATE( aff, SMAUG_AFF, 1 );
         aff->duration = STRALLOC( duration );

It was creating the affects even if returned and never freeing them (could lead to crashes or odd behavior).
If you did like 'sset <sn> affect waitstate' it would crash on saving/viewing/using the spell/skill.

       
Pages:<< prev 1 next >>