Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Couple bugs
Yesterday, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex, DotBot, Bing, Google

Members: 0
Guests: 6
Stats
Files
Topics
Posts
Members
Newest Member
477
3,705
19,232
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » [Bug] Array boundary exceeded...
Forum Rules | Mark all | Recent Posts

[Bug] Array boundary exceeded during socket buffer flush
< Newer Topic :: Older Topic > AFKMud 2.1

Pages:<< prev 1 next >>
Post is unread #1 Oct 5, 2008, 7:34 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Array boundary exceeded during socket buffer flush
Danger: High, with critical potential. Possible crashes or memory corruption due to array boundary overflow.
Discovered in: AFKMud 2.1
Found by: GCC 4.3
Fixed by: Samson

---

descriptor.cpp, descriptor_data::flush_buffer

Locate:
         buf[4096] = '\0';


Change to:
         buf[4095] = '\0';


GCC 4.3 issues the following warning:
descriptor.cpp: In member function 'bool descriptor_data::flush_buffer(bool)':
descriptor.cpp:528: warning: array subscript is above array bounds


Standard array buffer overflow. Guess it's never caused a problem before since it's never been reported. However NULLing memory outside of the array's boundary? Probably not such a hot idea.

Apparently some of the new warnings that have been enabled are actually useful.
       
Pages:<< prev 1 next >>