Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 Couple bugs
Yesterday, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Yandex, DotBot

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
477
3,705
19,232
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » AFKMud Bugfix List » [Bug] Pfile corruption if IMC...
Forum Rules | Mark all | Recent Posts

[Bug] Pfile corruption if IMC channels are denied, or if ignores are set
< Newer Topic :: Older Topic > AFKMud 2.03

Pages:<< prev 1 next >>
Post is unread #1 Feb 4, 2008, 6:42 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Pfile corruption if IMC channels are denied, or if ignores are set
Danger: Critical - Data corruption of player files when IMC connections are utilized
Discovered in: AFKMud 2.03
Found by: Samson
Fixed by: Samson

---

imc.cpp, imc_loadchar

Locate:
fread_string( IMC_DENY( ch ), fp );


Chage to:
fread_line( IMC_DENY( ch ), fp ); 


Locate:
         if( !strcasecmp( word, "IMCignore" ) )
         {
            string newign;

            fread_string( newign, fp );
            CH_IMCDATA( ch )->imc_ignore.push_back( newign );
            break;
         }


Change to:
         if( !strcasecmp( word, "IMCignore" ) )
         {
            string newign;

            fread_line( newign, fp );
            CH_IMCDATA( ch )->imc_ignore.push_back( newign );
            break;
         }


While this will have no affect on pfiles where IMC is not being used, it will cause data corruption in the player's inventory if they have set an ignore on someone or if they have been denied use of any of the network channels. The reason for this is because the data is saved with just a newline as the line terminator, but the loading function is expecting a tilde as a terminator. So the entire ignore list will get loaded as a single string, which does not terminate until the first tilde is encountered in the player's inventory data. This will of course cause that first item to be corrupted, and if left unchecked, will eventually corrupt their entire inventory.
       
Pages:<< prev 1 next >>