Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Bing, Majestic-12

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Memory allocation misma...
Forum Rules | Mark all | Recent Posts

[Bug] Memory allocation mismatch in hotboot
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 14, 2007, 11:06 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Memory allocation mismatch in hotboot
Danger: High - Memory leak + possible crash and/or data corruption
Found by: Keberus
Fixed by: Keberus

---

hotboot.c, load_ship

Locate:
         case 'T':
            KEY( "Torpedos", ship->torpedos, fread_number( fp ) );
            if( !str_cmp( word, "target0" ) )
            {
               char *temp = fread_string( fp );
               SHIP_DATA *target = get_ship( temp );

               ship->target0 = target;
               DISPOSE( temp );
               fMatch = TRUE;
               break;
            }

            if( !str_cmp( word, "target1" ) )
            {
               char *temp = fread_string( fp );
               SHIP_DATA *target = get_ship( temp );

               ship->target1 = target;
               DISPOSE( temp );
               fMatch = TRUE;
               break;
            }

            if( !str_cmp( word, "target2" ) )
            {
               char *temp = fread_string( fp );
               SHIP_DATA *target = get_ship( temp );

               ship->target2 = target;
               DISPOSE( temp );
               fMatch = TRUE;
               break;
            }
            break;


Change to:
         case 'T':
            KEY( "Torpedos", ship->torpedos, fread_number( fp ) );
            if( !str_cmp( word, "target0" ) )
            {
               char *temp = fread_string_nohash( fp );
               SHIP_DATA *target = get_ship( temp );

               ship->target0 = target;
               DISPOSE( temp );
               fMatch = TRUE;
               break;
            }

            if( !str_cmp( word, "target1" ) )
            {
               char *temp = fread_string_nohash( fp );
               SHIP_DATA *target = get_ship( temp );

               ship->target1 = target;
               DISPOSE( temp );
               fMatch = TRUE;
               break;
            }

            if( !str_cmp( word, "target2" ) )
            {
               char *temp = fread_string_nohash( fp );
               SHIP_DATA *target = get_ship( temp );

               ship->target2 = target;
               DISPOSE( temp );
               fMatch = TRUE;
               break;
            }
            break;


Yet another classic case of mismatched usage of fread_string and DISPOSE. Even though these are temporary variables being handled, DISPOSE operations on hashed strings can still cause major hurt to the allocated strings.
       
Pages:<< prev 1 next >>