Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 Couple bugs
Yesterday, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, DotBot

Members: 0
Guests: 15
Stats
Files
Topics
Posts
Members
Newest Member
477
3,705
19,232
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] do_clone removed bestow...
Forum Rules | Mark all | Recent Posts

[Bug] do_clone removed bestowments incorrectly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 29, 2006, 1:58 pm   Last edited Nov 23, 2006, 8:10 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: do_clone removed bestowments incorrectly
Danger: Medium - String data corruption. Possible crash.
Found by: Guido
Fixed by: Keberus

---

misc.c, do_clone

Locate:
   if( ch->pcdata->clan_name && ch->pcdata->clan_name[0] != '\0' )
   {
      strcpy( clanname, ch->pcdata->clan_name );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( "" );
      if( ch->pcdata->bestowments )
      {
         strcpy( bestowments, ch->pcdata->bestowments );
         STRFREE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = STRALLOC( "" );
      }
      save_clone( ch );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( clanname );
      if( bestowments[0] != '\0' )
      {
         STRFREE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = STRALLOC( bestowments );
      }
   }


Change to:
   if( ch->pcdata->clan_name && ch->pcdata->clan_name[0] != '\0' )
   {
      strcpy( clanname, ch->pcdata->clan_name );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( "" );
      if( ch->pcdata->bestowments )
      {
         strcpy( bestowments, ch->pcdata->bestowments );
         DISPOSE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = str_dup( "" );
      }
      save_clone( ch );
      STRFREE( ch->pcdata->clan_name );
      ch->pcdata->clan_name = STRALLOC( clanname );
      if( bestowments[0] != '\0' )
      {
         DISPOSE( ch->pcdata->bestowments );
         ch->pcdata->bestowments = str_dup( bestowments );
      }
   }


Yet another classic STRALLOC/DISPOSE mismatch.
       
Pages:<< prev 1 next >>