Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 8
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] plantbug skill can lead...
Forum Rules | Mark all | Recent Posts

[Bug] plantbug skill can lead to memory corruption
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 29, 2006, 1:40 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: plantbug skill can lead to memory corruption
Danger: Medium - Specific circumstances required to trigger it.
Found by: Phoneix Dracul
Fixed by: Keberus

---

hunter.c, do_plantbug

Locate:
      CREATE( pbug, BUG_DATA, 1 );
      pbug->name = ch->name;
      LINK( pbug, victim->first_bug, victim->last_bug, next_in_bug, prev_in_bug );


Change to:
      CREATE( pbug, BUG_DATA, 1 );
      pbug->name = QUICKLINK( ch->name );
      LINK( pbug, victim->first_bug, victim->last_bug, next_in_bug, prev_in_bug );


By setting the pbug->name field directly to the player name who did it, the code leaves open the possibility that the value will go NULL when the player leaves the game. Once this happens then whatever means are necessary to discover the information will trigger a crash, or possibly just point to garbage data.
       
Pages:<< prev 1 next >>