Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
Bug in do_drag( )
Oct 8, 2017, 12:40 am
By GatewaySysop
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Beastmaster 6D sound files
Author: Vladaar
Submitted by: Vladaar
Users Online
Yandex, CommonCrawl, DotBot

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
476
3,704
19,231
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » Fwrite_obj ...doesn't check a...
Forum Rules | Mark all | Recent Posts

Fwrite_obj ...doesn't check against null obj_data
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 25, 2006, 3:41 pm
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

I was wondering if fwrite_obj purposely overlooks null obj data or it should be checked. Phoneix Dracul had a core dump that pointed to this code being called on null obj_data, so it crashed his mud. The fix is simple.

The fix, in save.c fwrite_obj

after:
   if( iNest >= MAX_NEST )
   {
      bug( "fwrite_obj: iNest hit MAX_NEST %d", iNest );
      return;
   }


add:
   if( !obj )
   {
      bug( "%s", "fwrite_obj: NULL obj" );
      return;
   }


Just seems kinda obvious. I wonder why it was always overlooked?

Later,
KeB
       
Pages:<< prev 1 next >>