Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Sogou, DotBot, Yahoo!

Members: 0
Guests: 18
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] setclan type does not w...
Forum Rules | Mark all | Recent Posts

[Bug] setclan type does not work properly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Oct 7, 2006, 8:57 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: setclan type does not work properly
Danger: Low - Minor logic bug in the corporation condition
Found by: Phoenix Dracul/Guido
Fixed by: Keberus

---

clans.c, do_setclan

Locate:
      send_to_char( " guard1 guard2 patrol1 patrol2\r\n", ch );


Change to:
      send_to_char( " guard1 guard2 patrol1 patrol2 type\r\n", ch );


Locate:
   if( !strcmp( arg2, "type" ) )
   {
      if( clan->mainclan )
      {
         UNLINK( clan, clan->mainclan->first_subclan, clan->mainclan->last_subclan, next_subclan, prev_subclan );
         clan->mainclan = NULL;
      }
      if( !str_cmp( argument, "crime" ) )
         clan->clan_type = CLAN_CRIME;
      else if( !str_cmp( argument, "guild" ) )
         clan->clan_type = CLAN_GUILD;
      else if( !str_cmp( argument, "corp" ) )
         clan->clan_type = CLAN_CORPORATION;
      else if( !str_cmp( argument, "govn" ) )
         clan->clan_type = CLAN_PLAIN;
      else if( argument[0] == '\0' )
         send_to_char( "You must pick from the following: Crime, Guild, Corperation, or Government.\r\n", ch );
      send_to_char( "Done.\r\n", ch );
      save_clan( clan );
      return;
   }


Change to:
   if( !strcmp( arg2, "type" ) )
   {
      if( clan->mainclan )
      {
         UNLINK ( clan , clan->mainclan->first_subclan, clan->mainclan->last_subclan, next_subclan, prev_subclan );
         clan->mainclan = NULL;
      }
      if( !str_cmp( argument, "crime" ) )
         clan->clan_type = CLAN_CRIME;
      else if( !str_cmp( argument, "crime family" ) )
         clan->clan_type = CLAN_CRIME;
      else if( !str_cmp( argument, "guild" ) )
         clan->clan_type = CLAN_GUILD;
      else if( !str_cmp( argument, "corporation";) )
         clan->clan_type = CLAN_CORPORATION;
      else
         clan->clan_type = 0;
      send_to_char( "Done.\r\n", ch );
      save_clan( clan );
      return;
   }


Keberus said:


For those who can't look at the code, they may not know type is settable. The other is when you set type before it would hit the corporation check and set it to 0 if it wasn't corporation. Its just a small oversight and all I did was add in the else before it to make it fall through properly when applicable.
       
Pages:<< prev 1 next >>