Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex

Members: 0
Guests: 13
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Starsystem setup does n...
Forum Rules | Mark all | Recent Posts

[Bug] Starsystem setup does not validate planet names
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 30, 2006, 6:48 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Starsystem setup does not validate planet names
Danger: Low - Code is not validating input before changing names on planets.
Found by: Keberus
Fixed by: Keberus

---

space.c, do_setstarsystem

Locate:
   if( !str_cmp( arg2, "star2" ) )
   {
      STRFREE( starsystem->star2 );
      starsystem->star2 = STRALLOC( argument );
      send_to_char( "Done.\r\n", ch );
      save_starsystem( starsystem );
      return;
   }


Below that, add:
   /*Make sure the planet actually exists --Keberus and RapidRunner */
   if( !str_cmp( arg2, "planet1" ) || !str_cmp( arg2, "planet2" ) || !str_cmp( arg2, "planet3" ) )
   {
      PLANET_DATA *tplanet;
      bool pFound = FALSE;

      for( tplanet = first_planet; tplanet; tplanet = tplanet->next )
      {
         if( !str_cmp( tplanet->name, argument ) )
         {
            pFound = TRUE;
            break;
         }
      }

      if( !pFound )
      {
         ch_printf( ch, "&YThe planet &G%s &Ydoes not exist!\r\n", argument );
         return;
      }
   }


The starsystem code was allowing planets to be added to a starsystem even if that planet didn't exist.
       
Pages:<< prev 1 next >>