Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Codebases » SWFOTE FUSS » do_setstarsystem allows you t...
Forum Rules | Mark all | Recent Posts

do_setstarsystem allows you to set invalid planets
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 25, 2006, 8:04 pm
Go to the top of the page
Go to the bottom of the page

Keberus
Conjurer
GroupFUSS Project Team
Posts341
JoinedJun 4, 2005

do_setstarsystem allows you to set planets that don't actually exist. Basically there's not checking.
Onto the fix:

in: space.c
function: do_setstarystem
find:
   if( !str_cmp( arg2, "planet1" ) )
   {
      STRFREE( starsystem->planet1 );
      starsystem->planet1 = STRALLOC( argument );
      send_to_char( "Done.\r\n", ch );
      save_starsystem( starsystem );
      return;
   }


And before it add:
/*Make sure the planet actually exists --Keberus and RapidRunner */
    if( !str_cmp( arg2, "planet1" ) || !str_cmp( arg2, "planet2" ) || !str_cmp( arg2, "planet3" ) )
    {
        PLANET_DATA *tplanet;
        bool pFound = FALSE;

        for( tplanet = first_planet; tplanet; tplanet = tplanet->next)
        {
            if( !str_cmp(tplanet->name, argument ) )
            {
                 pFound = TRUE;
                 break;
            }
        }

         if( !pFound )
        {
            ch_printf(ch, "&YThe planet &G%s &Ydoes not exist!\n\r", argument );
            return;
        }
    }


This fix loops through all of the planets to make sure that one exists before allowing it to be set to the starsystem.

Later,
KeB
       
Pages:<< prev 1 next >>