Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot, Yahoo!, Bing

Members: 0
Guests: 28
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] do_fset and do_fhset do...
Forum Rules | Mark all | Recent Posts

[Bug] do_fset and do_fhset do not clean up all necessary strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 10, 2006, 12:24 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: do_fset and do_fhset do not clean up all necessary strings
Danger: High - Memory leak with possible corruption
Found by: Keberus
Fixed by: Keberus

---

force.c

Locate:
#include <errno.h>
#include "mud.h"


Below that, add:
void free_forceskill( FORCE_SKILL * fskill )
{
   short x;

   if( !fskill )
   {
      bug( "%s: null forceskill pointer!", __FUNCTION__ );
      return;
   }
     
   STRFREE( fskill->name );
   STRFREE( fskill->code );

   for( x = 0; x < 5; x++ )
   {
      STRFREE( fskill->room_effect[x] );
      STRFREE( fskill->victim_effect[x] );
      STRFREE( fskill->ch_effect[x] );
   }
   DISPOSE( fskill );
   return;
}

void free_forcehelp( FORCE_HELP * fhelp )
{
   if( !fhelp )
   {
      bug( "%s: null forcehelp pointer!", __FUNCTION__ );
      return;
   }

   STRFREE( fhelp->desc );
   STRFREE( fhelp->name );

   DISPOSE( fhelp );
   return;
}


force.c, do_fset

Locate:
      else if( !strcmp( arg2, "remove" ) )
      {
         UNLINK( fskill, first_force_skill, last_force_skill, next, prev );
         write_all_forceskills(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


Change to:
      else if( !strcmp( arg2, "remove" ) )
      {
         UNLINK( fskill, first_force_skill, last_force_skill, next, prev );
         free_forceskill( fskill );
         write_all_forceskills(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


force.c, do_fhset

Locate:
      else if( !strcmp( arg3, "remove" ) )
      {
         UNLINK( fhelp, first_force_help, last_force_help, next, prev );
         write_all_forcehelps(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


Change to:
      else if( !strcmp( arg3, "remove" ) )
      {
         UNLINK( fhelp, first_force_help, last_force_help, next, prev );
         free_forcehelp( fhelp );
         write_all_forcehelps(  );
         send_to_char( "Done.\r\n", ch );
         return;
      }


And yet another case of not cleaning up after deallocating something. This time leaving behind pretty much everything these two commands can create.
       
Pages:<< prev 1 next >>