Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
Bug in do_drag( )
Oct 8, 2017, 12:40 am
By GatewaySysop
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Beastmaster 6D sound files
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot, Yandex

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
476
3,704
19,231
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] free_char does not clea...
Forum Rules | Mark all | Recent Posts

[Bug] free_char does not clean up all necessary strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Sep 10, 2006, 12:14 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: free_char does not clean up all necessary strings
Danger: High - Memory leak with possible corruption
Found by: Keberus
Fixed by: Keberus

---

db.c, free_char

Locate:
   while( ( bugs = ch->first_bug ) != NULL )
   {
      UNLINK( bugs, ch->first_bug, ch->last_bug, next_in_bug, prev_in_bug );
      DISPOSE( bugs );
   }

   while( ( contract = ch->first_contract ) != NULL )
   {
      UNLINK( contract, ch->first_contract, ch->last_contract, next_in_contract, prev_in_contract );
      DISPOSE( contract );
   }

   while( ( fellow = ch->first_fellow ) != NULL )
   {
      UNLINK( fellow, ch->first_fellow, ch->last_fellow, next, prev );
      DISPOSE( fellow );
   }


Change to:
   while( ( bugs = ch->first_bug ) != NULL )
   {
      UNLINK( bugs, ch->first_bug, ch->last_bug, next_in_bug, prev_in_bug );
      STRFREE( bugs->name );
      DISPOSE( bugs );
   }

   while( ( contract = ch->first_contract ) != NULL )
   {
      UNLINK( contract, ch->first_contract, ch->last_contract, next_in_contract, prev_in_contract );
      DISPOSE( contract->target );
      DISPOSE( contract );
   }

   while( ( fellow = ch->first_fellow ) != NULL )
   {
      UNLINK( fellow, ch->first_fellow, ch->last_fellow, next, prev );
      STRFREE( fellow->knownas );
      STRFREE( fellow->victim );
      DISPOSE( fellow );
   }


Dangling strings left behind in memory when each player quits/logs out etc and is extracted from the game. Leaving these things behind eventually results in resource draining and can lead to data corruption in extreme cases.
       
Pages:<< prev 1 next >>