Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Sogou, Google

Members: 0
Guests: 2
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Deleting a project may ...
Forum Rules | Mark all | Recent Posts

[Bug] Deleting a project may corrupt memory while deleting log pointers
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 19, 2006, 1:08 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Deleting a project may corrupt memory while deleting log pointers
Danger: High - Corrupted project logs could result in a crash
Found by: Remcon
Fixed by: Samson

---

boards.c, delete_project

Locate:
   nlog = project->last_log;
   while( nlog )
   {
      UNLINK( nlog, project->first_log, project->last_log, next, prev );
      tlog = nlog->prev;
      free_note( nlog );
      nlog = tlog;
   }


Change to:
   for( nlog = project->first_log; nlog; nlog = tlog )
   {
      tlog = nlog->next;

      UNLINK( nlog, project->first_log, project->last_log, next, prev );
      free_note( nlog );
   }


The project log deletion does some oddball things with the memory pointers. The while loop may look sound, but it could actually result in screwing up the wrong logs, and its intention isn't entirely clear. Changing to the for loop solves the problem and is also easier to follow for future maintenance.
       
Pages:<< prev 1 next >>