Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Bad project log keyword...
Forum Rules | Mark all | Recent Posts

[Bug] Bad project log keyword will cause a memory leak
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 19, 2006, 12:58 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Bad project log keyword will cause a memory leak
Danger: Medium - Only occurs during bootup
Found by: Remcon
Fixed by: Remcon

---

db.c, read_log

Locate:
      else
      {
         DISPOSE( nlog );
         bug( "%s", "read_log: bad key word." );
         return NULL;
      }


Change to:
      else
      {
         STRFREE( nlog->sender );
         STRFREE( nlog->date );
         STRFREE( nlog->subject );
         STRFREE( nlog->text );
         DISPOSE( nlog );
         bug( "%s", "read_log: bad key word." );
         return NULL;
      }


If a bad keyword in a project file is encountered then the log is not disposed of properly. All of the text fields that might have been read in will be leaked into the string hash. This isn't a very critical leak though since it will only happen at bootup.
       
Pages:<< prev 1 next >>