Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Sogou, Bing

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] String checking argumen...
Forum Rules | Mark all | Recent Posts

[Bug] String checking arguments reversed
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Aug 13, 2006, 7:55 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: String checking arguments reversed
Danger: Low - Comparisons made are backward. Doesn't post overly large threat.
Found by: Remcon
Fixed by: Remcon/Mordecai

---

imm_host.c, check_immortal_domain

Locate:
         if( temp->prefix && temp->suffix && strstr( temp->host, my_host ) )
            return TRUE;


Change to:
         if( temp->prefix && temp->suffix && strstr( my_host, temp->host ) )
            return TRUE;


act_wiz.c, do_ipcompare

Locate:
      if( prefix && suffix && strstr( addie, d->host ) )
         fMatch = TRUE;


Change to:
      if( prefix && suffix && strstr( d->host, addie ) )
         fMatch = TRUE;


ban.c, check_total_bans

Locate:
      if( pban->level != LEVEL_SUPREME )
         continue;
      if( pban->prefix && pban->suffix && strstr( pban->name, new_host ) )


Change to:
      if( pban->level != LEVEL_SUPREME )
         continue;
      if( pban->prefix && pban->suffix && strstr( new_host, pban->name ) )


All of the above are classic cases of strstr being called with its arguments in a reversed order. Usually resulting in a failed check but not often having any dangerous side affects.
       
Pages:<< prev 1 next >>