Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
6Dragons 4.4
Author: Vladaar
Submitted by: Vladaar
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing, DotBot, Yandex

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
479
3,708
19,242
614
BenitoVirg
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Extracting mounted NPCs...
Forum Rules | Mark all | Recent Posts

[Bug] Extracting mounted NPCs resets the wrong bit flag
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jul 29, 2006, 10:38 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Extracting mounted NPCs resets the wrong bit flag
Danger: Medium - Unpredictable effects depending on which flag is incorrectly reset
Found by: Kiasyn
Fixed by: Kiasyn

---

handler.c, extract_char

Locate:
   if( IS_NPC( ch ) && IS_SET( ch->act, ACT_MOUNTED ) )
      for( wch = first_char; wch; wch = wch->next )
         if( wch->mount == ch )
         {
            wch->mount = NULL;
            wch->position = POS_STANDING;
         }

   REMOVE_BIT( ch->act, ACT_MOUNTED );


Change to:
   if( IS_NPC( ch ) && IS_SET( ch->act, ACT_MOUNTED ) )
   {
      for( wch = first_char; wch; wch = wch->next )
      {
         if( wch->mount == ch )
         {
            wch->mount = NULL;
            wch->position = POS_STANDING;
         }
      }
      REMOVE_BIT( ch->act, ACT_MOUNTED );
   }


This bug is very sutble and would probably have been undetected for a long time had it not been for Kiasyn's eagle eye here. The check for removing the ACT_MOUNTED flag appears perfectly valid and will not trigger any bug messages. But it does not verify that it's being done on an NPC. Players and NPCs in Smaug share the ch->act bit and so on players this bit reset could have any number of undesired affects depending on what changes have been made in the code. For stock FUSS code, this would have removed the PLR_LOG bit which under the vast majority of cases would never have been noticed.
       
Pages:<< prev 1 next >>