Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
Bug in do_drag( )
Oct 8, 2017, 12:40 am
By GatewaySysop
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Beastmaster 6D sound files
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Google, Bing

Members: 0
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
476
3,704
19,231
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Skills not freeing all ...
Forum Rules | Mark all | Recent Posts

[Bug] Skills not freeing all required information
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 27, 2006, 9:54 am   Last edited May 27, 2006, 10:00 am by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Skills not freeing all required information
Danger: Trivial - Memory leak: spell_fun_name and skill_fun_name need to be freed
Found by: Remcon
Fixed by: Remcon

---

skills.c, free_skill

Locate:
   DISPOSE( skill->imm_char );
   DISPOSE( skill->imm_vict );
   DISPOSE( skill->imm_room );
   DISPOSE( skill->dice );


Below that, add:
   if( skill->spell_fun_name )
      DISPOSE( skill->spell_fun_name );
   if( skill->skill_fun_name )
      DISPOSE( skill->skill_fun_name );


Even though this is technically a memory leak bug, the free_skill function is only called at shutdown during the cleanup_memory process. Otherwise this will have no impact, unless you've modified your code to allow skills to be deleted online.
       
Pages:<< prev 1 next >>