Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Google, DotBot, Sogou

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Color theme file is not...
Forum Rules | Mark all | Recent Posts

[Bug] Color theme file is not closed properly in an error condition
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 13, 2006, 2:28 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Color theme file is not closed properly in an error condition
Danger: Medium - Leaves file descriptors hanging open
Found by: Halcyon
Fixed by: Halcyon

---

color.c, do_color

Locate:
      ch_printf( ch, "An error occured while trying to set color theme %s.\r\n", argument );
      return;


Change to:
      fclose( fp );
      fp = NULL;
      ch_printf( ch, "An error occured while trying to set color theme %s.\r\n", argument );
      return;


If a color theme file reaches EOF prematurely, then the file is not closing out properly. Leaving enough files dangling open can cause resource shortages and in general just creates problems.
       
Pages:<< prev 1 next >>