Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Bing

Members: 0
Guests: 9
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Line editor input not c...
Forum Rules | Mark all | Recent Posts

[Bug] Line editor input not consistent with file I/O behaviour
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jan 30, 2006, 3:19 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Line editor input not consistent with file I/O behaviour
Danger: Medium - Will break any mudprog entered via OLC before the mud reboots.
Found by: Stan
Fixed by: Samson

---

editor.c, editdata_to_str

Locate:
      buf[i++] = '\n';
      buf[i++] = '\r';
      used += 2;


And change it to:
      buf[i++] = '\n';
      used++;


If you have not yet done the telnet protocol fix where \n\r is replaced with \r\n, you won't be affected by the bug but should probably still fix it anyway.

This is one of those stupid things that even after looking at it and banging heads against walls still fails to make alot of sense, but nonetheless, having the line editor only use \n (LF) to signify a newline seems to be the proper solution to this. Since mudprogs are saved to disk with \r (CR) stripped the behaviour of the line editor now properly follows the same standard used by the file I/O systems. And it can never hurt anything to use consistent behaviour, right? We've just seen what happens when you don't!
       
Pages:<< prev 1 next >>