Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
613
bastian
Today's Birthdays
Evoru (32)
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Banning with prefix+suf...
Forum Rules | Mark all | Recent Posts

[Bug] Banning with prefix+suffix set does not work
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Dec 18, 2005, 12:59 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Banning with prefix+suffix set does not work.
Danger: Low - Will miss checks like *.0.0.*
Found by: Remcon
Fixed by: Samson

---

ban.c, check_bans

Locate:
         if( pban->prefix && pban->suffix && strstr( pban->name, new_host ) )
            fMatch = TRUE;


Change to:
         if( pban->prefix && pban->suffix && strstr( new_host, pban->name ) )
            fMatch = TRUE;


ban.c, check_total_bans

Locate:
      if( pban->prefix && pban->suffix && strstr( pban->name, new_host ) )
      {
         if( check_expire( pban ) )
         {
            dispose_ban( pban, BAN_SITE );
            save_banlist(  );
            return FALSE;
         }
         else
            return TRUE;
      }


Change to:
      if( pban->prefix && pban->suffix && strstr( new_host, pban->name ) )
      {
         if( check_expire( pban ) )
         {
            dispose_ban( pban, BAN_SITE );
            save_banlist(  );
            return FALSE;
         }
         else
            return TRUE;
      }


The reason why prefix+suffix bans does not work as originally implemented is because of how the strstr function works. The first argument for it should be the total string you have, in this case new_host, and the second argument is what you are looking for, in this case pban->name. The code had the order reversed and so it would always return NULL and cause the check to fail. Apparently prefix+suffix bans are not used much or this would have been spotted alot sooner.
       
Pages:<< prev 1 next >>