Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Couple bugs
Yesterday, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, DotBot, Yandex, Google, Yahoo!

Members: 0
Guests: 3
Stats
Files
Topics
Posts
Members
Newest Member
477
3,705
19,232
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Prototype check in mset...
Forum Rules | Mark all | Recent Posts

[Bug] Prototype check in mset command can crash the game
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 8, 2005, 8:14 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Prototype check in mset command can crash the game
Danger: High - Will crash if a PLR flag has the same value as an ACT flag and is edited on a PC.
Found by: Qidexan
Fixed by: Qidexan/Samson

---

build.c, do_mset

In the "flags" section, locate:
      if( IS_SET( victim->act, ACT_PROTOTYPE ) )
         protoflag = TRUE;


Change to:
      if( IS_NPC( victim ) && IS_SET( victim->act, ACT_PROTOTYPE ) )
         protoflag = TRUE;


Locate:
      if( IS_SET( victim->act, ACT_PROTOTYPE ) || ( value == ACT_PROTOTYPE && protoflag ) )
         victim->pIndexData->act = victim->act;


Change to:
      if( IS_NPC( victim ) && ( IS_SET( victim->act, ACT_PROTOTYPE ) || ( 1 << value == ACT_PROTOTYPE && protoflag ) ) )
         victim->pIndexData->act = victim->act;


The prototype checking in this function is not verifying that the victim is an NPC. While the first check would remain relatively harmless, the second one will result in a crash if the PC being edited happens to have the PLR flag with the same numerical value set.
       
Pages:<< prev 1 next >>