Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Bing, Yandex, Yahoo!

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
612
Jacki72H
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] strip_cr function has n...
Forum Rules | Mark all | Recent Posts

[Bug] strip_cr function has no protection against NULL strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 6, 2005, 1:51 pm   Last edited Nov 27, 2005, 2:03 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: strip_cr function has no protection against NULL strings
Danger: Critical - Can lead to crashes and corrupted data.
Found by: Samson
Fixed by: Samson

---

build.c, strip_cr

Locate:
   static char newstr[MAX_STRING_LENGTH];
   int i, j;


Change to:
   static char newstr[MAX_STRING_LENGTH];
   int i, j;

   if( !str || str[0] == '\0' )
      return "";


This simple fix will prevent the strip_cr function from bringing the game down at a most inopportune moment with a NULL string being fed to it. This function is used heavily in the saving of area files so it represents an especially dangerous threat if left unprotected. When fed a NULL string this fix will return just an empty one which is perfectly safe.

EDIT: This fix was edited to remove the bug message due to spam reports. The NULL string protection is still vital however and should not be removed completely.
       
Pages:<< prev 1 next >>