Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
Bug in do_drag( )
Oct 8, 2017, 12:40 am
By GatewaySysop
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Beastmaster 6D sound files
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, DotBot

Members: 0
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
476
3,704
19,231
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] strip_cr function has n...
Forum Rules | Mark all | Recent Posts

[Bug] strip_cr function has no protection against NULL strings
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 6, 2005, 1:51 pm   Last edited Nov 27, 2005, 2:03 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: strip_cr function has no protection against NULL strings
Danger: Critical - Can lead to crashes and corrupted data.
Found by: Samson
Fixed by: Samson

---

build.c, strip_cr

Locate:
   static char newstr[MAX_STRING_LENGTH];
   int i, j;


Change to:
   static char newstr[MAX_STRING_LENGTH];
   int i, j;

   if( !str || str[0] == '\0' )
      return "";


This simple fix will prevent the strip_cr function from bringing the game down at a most inopportune moment with a NULL string being fed to it. This function is used heavily in the saving of area files so it represents an especially dangerous threat if left unprotected. When fed a NULL string this fix will return just an empty one which is perfectly safe.

EDIT: This fix was edited to remove the bug message due to spam reports. The NULL string protection is still vital however and should not be removed completely.
       
Pages:<< prev 1 next >>