Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
Bug in get_exp_worth( )
Oct 10, 2017, 1:26 am
By GatewaySysop
Bug in do_drag( )
Oct 8, 2017, 12:40 am
By GatewaySysop
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Beastmaster 6D sound files
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Bing, Yahoo!, DotBot, Sogou

Members: 0
Guests: 4
Stats
Files
Topics
Posts
Members
Newest Member
476
3,704
19,231
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWR FUSS Bugfix List » [Bug] Bestow command handles ...
Forum Rules | Mark all | Recent Posts

[Bug] Bestow command handles arguments improperly
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Nov 5, 2005, 7:50 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Bestow command handles arguments improperly
Danger: Low - Cuts of a portion of input argument
Found by: Remcon
Fixed by: Remcon

---

act_wiz.c, do_bestow

Locate:
   char arg[MAX_INPUT_LENGTH], buf[MAX_STRING_LENGTH], arg_buf[MAX_STRING_LENGTH];
   CHAR_DATA *victim;


Change to:
   char arg[MAX_INPUT_LENGTH], buf[MAX_STRING_LENGTH], arg_buf[MAX_STRING_LENGTH];
   char tmparg[MAX_INPUT_LENGTH];
   CHAR_DATA *victim;


Locate:
      sprintf( arg, "%s ", arg );
      strcat( arg_buf, arg );
      argument = one_argument( argument, arg );


Change to:
      snprintf( tmparg, MAX_INPUT_LENGTH, "%s ", arg );
      strncat( arg_buf, tmparg, MAX_STRING_LENGTH );
      argument = one_argument( argument, arg );


This fixes the sizing of the arg_buf string which then lets the command do everything it is intended to do.
       
Pages:<< prev 1 next >>