Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Bing

Members: 0
Guests: 5
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] Clan member count is no...
Forum Rules | Mark all | Recent Posts

[Bug] Clan member count is not safeguarded against going negative
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 9, 2005, 9:33 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Clan member count is not safeguarded against going negative in do_mset and do_outcast
Danger: Low - Incorrect counter value
Found by: Celestria
Fixed by: Celestria

---

build.c, do_mset

Locate:

      if( !arg3 || arg3[0] == '\0' )
      {
         if( victim->pcdata->clan == NULL )
            return;
         remove_member( victim->name, victim->pcdata->clan->shortname );
         STRFREE( victim->pcdata->clan_name );
         victim->pcdata->clan_name = STRALLOC( "" );
         victim->pcdata->clan = NULL;
         send_to_char
            ( "Removed from clan.\n\rPlease make sure you adjust that clan's members accordingly.\n\rAlso be sure to remove any bestowments they have been given.\n\r",
              ch );
         return;
      }


Change to:

      if( !arg3 || arg3[0] == '\0' )
      {
         if( victim->pcdata->clan == NULL )
            return;
         remove_member( victim->name, victim->pcdata->clan->shortname );
         --victim->pcdata->clan->members; 
         save_clan( victim->pcdata->clan );
         STRFREE( victim->pcdata->clan_name );
         victim->pcdata->clan_name = STRALLOC( "" );
         victim->pcdata->clan = NULL;
         send_to_char( "Removed from clan.\n\r", ch );
         return;
      }


Locate:

      if( victim->pcdata->clan )
         remove_member( victim->name, victim->pcdata->clan->shortname );

      STRFREE( victim->pcdata->clan_name );
      victim->pcdata->clan_name = QUICKLINK( clan->name );
      victim->pcdata->clan = clan;
      add_member( victim->name, victim->pcdata->clan->shortname );
      send_to_char( "Done.\n\rPlease make sure you adjust that clan's members accordingly.\n\r", ch );


Change to:

      if( victim->pcdata->clan )
         remove_member( victim->name, victim->pcdata->clan->shortname );

      --victim->pcdata->clan->members; 
      if( victim->pcdata->clan->members < 0 )
         victim->pcdata->clan->members = 0;
      save_clan( victim->pcdata->clan );

      STRFREE( victim->pcdata->clan_name );
      victim->pcdata->clan_name = QUICKLINK( clan->name );
      victim->pcdata->clan = clan;
      add_member( victim->name, victim->pcdata->clan->shortname );
      save_clan( victim->pcdata->clan );
      send_to_char( "Done.\n\r", ch );


clans.c, do_outcast

Locate:

/*    if ( victim->speaking & LANG_CLAN )
        victim->speaking = LANG_BASIC;
    REMOVE_BIT( victim->speaks, LANG_CLAN );*/
   --clan->members;


Change to:

/*    if ( victim->speaking & LANG_CLAN )
        victim->speaking = LANG_BASIC;
    REMOVE_BIT( victim->speaks, LANG_CLAN );*/
    --clan->members;
    if( clan->members < 0 )
       clan->members = 0;


Accuracy of clan membership information is somewhat important.
       
Pages:<< prev 1 next >>