Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, DotBot, Google

Members: 0
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SWFOTE FUSS Bugfix List » [Bug] New routers don't get a...
Forum Rules | Mark all | Recent Posts

[Bug] New routers don't get added to the linked list, memory leak
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 6, 2005, 12:14 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: New routers don't get added to the linked list, resulting in a memory leak.
Danger: High - Memory leak
Found by: Samson
Fixed by: Samson

---

i3.c, i3_router

Locate:
      I3CREATE( router, ROUTER_DATA, 1 );
      I3LINK( router, first_router, last_router, next, prev );
      router->name = I3STRALLOC( rtname );
      router->ip = I3STRALLOC( rtip );
      router->port = rtport;
      router->reconattempts = 0;


Below it, add:
      I3LINK( router, first_router, last_router, next, prev );


Using the i3router command to add new routers goes through the motions of allocating the memory space for the new router and setting the parameters you entered, but it is never linked to the list, resulting in a memory leak. The new router also is not saved into your configuration list because of this.

This bug affects all versions of the client prior to 2.40b and any codebases which may have included it will need to have this corrected.
       
Pages:<< prev 1 next >>