Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex, DotBot, Bing, Google

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] add_kill checks are not...
Forum Rules | Mark all | Recent Posts

[Bug] add_kill checks are not checking against PC victims
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jul 30, 2005, 9:42 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: add_kill checks are not checking against PC victims
Danger: Low - Bug spam
Found by: Zeno
Fixed by: Gatewaysysop/Samson

---

fight.c, damage

Locate:
      else if( !IS_NPC( ch ) )   /* keep track of mob vnum killed */
         add_kill( ch, victim );

      /*
       * Add to kill tracker for grouped chars, as well. -Halcyon
       */
      for( gch = ch->in_room->first_person; gch; gch = gch->next_in_room )
         if( is_same_group( gch, ch ) && !IS_NPC( gch ) && gch != ch )
            add_kill( gch, victim );


Replace with:

      else if( !IS_NPC( ch ) && IS_NPC( victim ) )   /* keep track of mob vnum killed */
      {
         add_kill( ch, victim );

         /*
          * Add to kill tracker for grouped chars, as well. -Halcyon
          */
         for( gch = ch->in_room->first_person; gch; gch = gch->next_in_room )
            if( is_same_group( gch, ch ) && !IS_NPC( gch ) && gch != ch )
               add_kill( gch, victim );
      }


Halcyon's original fix to the add_kill problem failed to take PC victims into account and was passing them to the add_kill function which has a check to prevent PCs from being added to the kill tracking. This generated a bug message, correctly, to alert the imms of the problem.

Secondary note - this bug is a prime example of why these fixes need to be applied in the order they are posted in. This one depends on a previous FUSS fix.
       
Pages:<< prev 1 next >>