Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Bing

Members: 0
Guests: 11
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] immune_casting checks w...
Forum Rules | Mark all | Recent Posts

[Bug] immune_casting checks wrong variable when missing a character
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Jul 30, 2005, 8:47 am
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: immune_casting checks wrong variable when missing a character.
Danger: Medium - NULL string access, bug message
Found by: Zeno
Fixed by: Zeno

---

magic.c, immune_casting

Locate:
      else if( skill->miss_char && skill->miss_char[0] != '\0' )
      {
         if( str_cmp( skill->hit_char, SPELL_SILENT_MARKER ) )
            act( AT_MAGIC, skill->hit_char, ch, obj, victim, TO_CHAR );
      }


Replace with:

      else if( skill->miss_char && skill->miss_char[0] != '\0' )
      {
         if( str_cmp( skill->miss_char, SPELL_SILENT_MARKER ) )
            act( AT_MAGIC, skill->miss_char, ch, obj, victim, TO_CHAR );
      }


Because this part of the function is checking the wrong pointer, it can lead to string comparison log messages, and possible crashes due to a NULL string access. Obviously if it's checking miss_char, it should display the miss_char message.
       
Pages:<< prev 1 next >>