Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Today, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Google, Remcon

Members: 1
Guests: 14
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] Clan member count can g...
Forum Rules | Mark all | Recent Posts

[Bug] Clan member count can go negative in do_mset and do_outcast
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 9, 2005, 8:07 pm
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: Clan member count is not safeguarded against going negative in do_mset and do_outcast
Danger: Low - Incorrect counter value
Found by: Celestria
Fixed by: Celestria

---

build.c, do_mset

Locate:

	    /* Added a check on immortals so immortals don't take up
	     * any membership space. --Shaddai
	     */
	   if( !IS_IMMORTAL( victim ) ) 
	    {
  	        --victim->pcdata->clan->members; 
	        save_clan( victim->pcdata->clan );
	    }


Change to:

	    /* Added a check on immortals so immortals don't take up
	     * any membership space. --Shaddai
	     */
	   if( !IS_IMMORTAL( victim ) ) 
	    {
  	        --victim->pcdata->clan->members; 
                if( victim->pcdata->clan->members < 0 )
                   victim->pcdata->clan->members = 0;
	        save_clan( victim->pcdata->clan );
	    }


Locate:

	if( victim->pcdata->clan != NULL && !IS_IMMORTAL( victim ) )
	{
		--victim->pcdata->clan->members; 
	        save_clan( victim->pcdata->clan );
      }


Change to:

	if( victim->pcdata->clan != NULL && !IS_IMMORTAL( victim ) )
	{
		--victim->pcdata->clan->members; 
                if( victim->pcdata->clan->members < 0 )
                   victim->pcdata->clan->members = 0;
	        save_clan( victim->pcdata->clan );
      }


clans.c, do_outcast

Locate:

   if( victim->speaking & LANG_CLAN )
        victim->speaking = LANG_COMMON;
    REMOVE_BIT( victim->speaks, LANG_CLAN );
    --clan->members;


Change to:

   if( victim->speaking & LANG_CLAN )
        victim->speaking = LANG_COMMON;
    REMOVE_BIT( victim->speaks, LANG_CLAN );
    --clan->members;
    if( clan->members < 0 )
       clan->members = 0;


Same as the deity fixes, information accuracy is important.
       
Pages:<< prev 1 next >>