Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Bing, Yahoo!

Members: 0
Guests: 16
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
613
bastian
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] New I3 routers don't ge...
Forum Rules | Mark all | Recent Posts

[Bug] New I3 routers don't get added to the linked list, memory leak
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 May 6, 2005, 12:14 pm   Last edited May 11, 2005, 7:07 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: New I3 routers don't get added to the linked list, resulting in a memory leak.
Danger: High - Memory leak
Found by: Samson
Fixed by: Samson

---

i3.c, i3_router

Locate:
      I3CREATE( router, ROUTER_DATA, 1 );
      I3LINK( router, first_router, last_router, next, prev );
      router->name = I3STRALLOC( rtname );
      router->ip = I3STRALLOC( rtip );
      router->port = rtport;
      router->reconattempts = 0;


Below it, add:
      I3LINK( router, first_router, last_router, next, prev );


Using the i3router command to add new routers goes through the motions of allocating the memory space for the new router and setting the parameters you entered, but it is never linked to the list, resulting in a memory leak. The new router also is not saved into your configuration list because of this.

This bug affects all versions of the client prior to 2.40b and any codebases which may have included it will need to have this corrected.
       
Pages:<< prev 1 next >>