Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
 parse description bug
Yesterday, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
Bug in will_fall( )
Oct 23, 2017, 1:35 am
By GatewaySysop
Bug in do_zap( ), do_brandish( )
Oct 18, 2017, 1:52 pm
By GatewaySysop
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Memwatch
Author: Johan Lindh
Submitted by: Vladaar
Users Online
CommonCrawl, Yahoo!, Yandex, DotBot, Bing, Google

Members: 0
Guests: 7
Stats
Files
Topics
Posts
Members
Newest Member
477
3,706
19,240
608
LAntorcha
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] save_equipment array is...
Forum Rules | Mark all | Recent Posts

[Bug] save_equipment array is defined with a hardcoded value
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005, 4:06 pm   Last edited May 11, 2005, 6:56 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: save_equipment array is defined with a hardcoded value.
Danger: Medium - Data will only be affected if MAX_LAYERS value is raised beyond the limit.
Found by: Samson
Fixed by: Samson

---

save.c, locate:

/*
 * Array to keep track of equipment temporarily.                -Thoric
 */
OBJ_DATA *save_equipment[MAX_WEAR][8];
CHAR_DATA *quitting_char, *loading_char, *saving_char;


Change to:

/*
 * Array to keep track of equipment temporarily.                -Thoric
 */
OBJ_DATA *save_equipment[MAX_WEAR][MAX_LAYERS];
CHAR_DATA *quitting_char, *loading_char, *saving_char;


The save_equipment array is a temporary storage spaces for equipment locations during certain operations. The external definition in mud.h defines the second array parameter as MAX_LAYERS, which by default is set to 8. Normally this creates no issues since it's doubtful many muds use more than 8 layers for any locations. However, should this value be raised, then the declaration in save.c will be invalid and cause overflows when the space is used.
       
Pages:<< prev 1 next >>