Login
User Name:

Password:



Register
Forgot your password?
Vote for Us!
auth_update crash
Dec 23, 2017, 10:15 pm
By Remcon
check_tumble
Dec 18, 2017, 7:21 pm
By Remcon
parse description bug
Dec 15, 2017, 10:08 pm
By Remcon
Couple bugs
Dec 12, 2017, 5:42 pm
By Remcon
Bug in disarm( )
Nov 12, 2017, 6:54 pm
By GatewaySysop
LoP 1.46
Author: Remcon
Submitted by: Remcon
LOP 1.45
Author: Remcon
Submitted by: Remcon
LOP Heroes Edition
Author: Vladaar
Submitted by: Vladaar
Heroes sound extras
Author: Vladaar
Submitted by: Vladaar
6Dragons 4.3
Author: Vladaar
Submitted by: Vladaar
Users Online
CommonCrawl, Yandex, Bing, Yahoo!

Members: 0
Guests: 10
Stats
Files
Topics
Posts
Members
Newest Member
478
3,708
19,242
613
bastian
Today's Birthdays
There are no member birthdays today.
Related Links
» SmaugMuds.org » Bugfix Lists » SmaugFUSS Bugfix List » [Bug] check_skill is passing ...
Forum Rules | Mark all | Recent Posts

[Bug] check_skill is passing invalid argument type to failed_casting
< Newer Topic :: Older Topic >

Pages:<< prev 1 next >>
Post is unread #1 Mar 5, 2005, 4:01 pm   Last edited May 11, 2005, 6:46 pm by Samson
Go to the top of the page
Go to the bottom of the page

Samson
Black Hand
GroupAdministrators
Posts3,639
JoinedJan 1, 2002

Bug: check_skill is passing an invalid argument type to the failed_casting function.
Danger: Medium
Found by: g++ compiler
Fixed by: Samson

The code is passing a void *vo pointer to failed_casting in the victim slot when vo could be assigned
to an object. This is obviously improper usage of the variable.

[skills.c]

In check_skill, locate the call to failed_casting.

It looks like so:

failed_casting( skill_table[sn], ch, vo, obj );

Change it to:

failed_casting( skill_table[sn], ch, victim, obj );

A bit further up, under case TAR_CHAR_SELF:
Make sure you have a line that says: victim = ch;

This bug could be the source of some strange crashes with certain skills.
Kylotan also reports this bug does not appear to affect Smaug 1.02a, only the 1.4a branch.
       
Pages:<< prev 1 next >>